Java: Add manual overlay annotations & discard predicates #19813
+147
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Java
DataFlow Library
C#
JS
C++
documentation
Python
Go
Ruby
QL-for-QL
Rust
kaspersv
force-pushed
the
kaspersv/overlay-java-discarding
branch
from
6f5bc41 to
8672313
Compare
github-actions
bot
removed
C#
JS
C++
documentation
Python
Go
Ruby
QL-for-QL
Rust
kaspersv
force-pushed
the
kaspersv/overlay-java-discarding
branch
from
8672313 to
db52a3c
Compare
jbj
reviewed
Jun 20, 2025
| // bodies for dependencies. To approximate fully extracted files in | ||
| // the overlay, we restrict attention to files that contain an expression | ||
| // with an enclosing callable. | ||
| exists(@expr e | callableEnclosingExpr(e, _) and file = getRawFile(e)) |
There was a problem hiding this comment.
@smowton suggested in the internal issue for "Java overlay: Low-level accuracy issues" to use the numlines table instead of callableEnclosingExpr to identify non-skeleton files.
I'm fine with postponing that change (and its evaluation) to a follow-up PR.
| @@ -26,6 +26,7 @@ import semmle.code.java.KotlinType | |||
| import semmle.code.java.Member | |||
| import semmle.code.java.Modifier | |||
| import semmle.code.java.Modules | |||
| import semmle.code.java.Overlay | |||
There was a problem hiding this comment.
This import will bring four top-level predicates into the global scope, visible in autocomplete everywhere. I think this would be better as a private import in each of the files that define a discard predicate.
| exists(@member m | file = getRawFile(m) and hasJavadoc(m, d)) | ||
| } | ||
|
|
||
| /** Discard javadoc entities in files fully extracted in the overlay. */ |
There was a problem hiding this comment.
Shouldn't we also have discarding rules for comments that aren't Javadoc?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.